Topology ports semantics #855
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logy-ports-semantics
…ology-ports-semantics
…ology-ports-semantics
…ology-ports-semantics
…ology-ports-semantics
bocchino
reviewed
Jan 29, 2026
bocchino
reviewed
Jan 29, 2026
compiler/tools/fpp-check/test/connection_direct/invalid_port_instance.ref.txt
Outdated
Show resolved
Hide resolved
bocchino
reviewed
Jan 29, 2026
compiler/tools/fpp-check/test/connection_direct/undef_instance.ref.txt
Outdated
Show resolved
Hide resolved
bocchino
reviewed
Jan 29, 2026
compiler/tools/fpp-check/test/port_matching/p2_not_port_instance.ref.txt
Outdated
Show resolved
Hide resolved
bocchino
reviewed
Jan 29, 2026
bocchino
reviewed
Jan 29, 2026
| loc: Location // The location whether the connection is requested | ||
| ): Result.Result[Unit] = Right(()) | ||
|
|
||
| override def equals(obj: Any): Boolean = |
Collaborator
There was a problem hiding this comment.
Why do we need to override equals here? What happens if we use the default equals?
Collaborator
Author
There was a problem hiding this comment.
This is required because we need a slightly more permissive == compared to default. This is so that we can compute port interfaces as sets of port instances. The default rule will also check the node.id which is not relevant for port instance but just for error reporting.
bocchino
reviewed
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements topology port semantics according to the spec from #748
Interesting Changes
interfaceInstanceUseportMap+specialPortMapwere moved out into a separatePortInterfaceconstruct so that it could be reused inside topologyPortInstance.Topologyfor wrapping ports with a new name to impement topology ports.Closes #745